linux-kernel - Re: [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by etm_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910222840.GB590446@xps15>
Date:   Thu, 10 Sep 2020 16:28:40 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Tingwei Zhang <tingwei@...eaurora.org>
Cc:     Suzuki K Poulose <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Mike Leach <mike.leach@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Leo Yan <leo.yan@...aro.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Russell King <linux@...linux.org.uk>,
        Kim Phillips <kim.phillips@....com>,
        Mian Yousaf Kaukab <ykaukab@...e.de>, tsoni@...eaurora.org,
        Sai Prakash Ranjan <saiprakash.ranjan@...eaurora.org>,
        Mao Jinlong <jinlmao@...eaurora.org>,
        coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by
 etm_setup_aux failure

On Fri, Aug 21, 2020 at 11:44:29AM +0800, Tingwei Zhang wrote:
> When coresight_build_path() fails on all the cpus, etm_setup_aux
> calls etm_free_aux() to free allocated event_data.
> WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty.
> Check event_data->snk_config is not NULL first to avoid this
> warning.
> 
> Signed-off-by: Tingwei Zhang <tingwei@...eaurora.org>
> Reviewed-by: Mike Leach <mike.leach@...aro.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>
> Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>

What happend to the Fixed tag that was in V8?  This is casting doubts on the
reset of this set.  

> ---
>  drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index dcb0592418ae..3728c44e5763 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data *event_data)
>  	cpumask_t *mask = &event_data->mask;
>  	struct coresight_device *sink;
>  
> -	if (WARN_ON(cpumask_empty(mask)))
> +	if (!event_data->snk_config)
>  		return;
>  
> -	if (!event_data->snk_config)
> +	if (WARN_ON(cpumask_empty(mask)))
>  		return;
>  
>  	cpu = cpumask_first(mask);
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>