linux-kernel - Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200911.143822.1454479961504655918.davem@davemloft.net>
Date:   Fri, 11 Sep 2020 14:38:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, olteanv@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, kuba@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not
 filtering

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 11 Sep 2020 11:28:27 -0700

> 
> 
> On 9/10/2020 9:19 PM, Florian Fainelli wrote:
>> Update the B53 driver to support VLANs while not filtering. This
>> requires us to enable VLAN globally within the switch upon driver
>> initial configuration (dev->vlan_enabled).
>> We also need to remove the code that dealt with PVID re-configuration
>> in
>> b53_vlan_filtering() since that function worked under the assumption
>> that it would only be called to make a bridge VLAN filtering, or not
>> filtering, and we would attempt to move the port's PVID accordingly.
>> Now that VLANs are programmed all the time, even in the case of a
>> non-VLAN filtering bridge, we would be programming a default_pvid for
>> the bridged switch ports.
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> 
> David, Jakub, please hold off applying this just yet, Vladimir has
> submitted another patch for testing that would be IMHO a better way to
> deal with DSA switches that have an egress tagged
> default_pvid. Depending on the outcome of that patch, I will resubmit
> this one or request that you apply it.

Ok.