linux-kernel - Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200911.144121.2042949892921941512.davem@davemloft.net>
Date:   Fri, 11 Sep 2020 14:41:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lee.jones@...aro.org,
        gustavoars@...nel.org, krzk@...nel.org
Subject: Re: [PATCH net-next] net/socket.c: Remove an unused header file
 <linux/if_frad.h>

From: Xie He <xie.he.0141@...il.com>
Date: Thu, 10 Sep 2020 23:07:20 -0700

> This header file is not actually used in this file. Let's remove it.

How did you test this assertion?  As Jakub showed, the
dlci_ioctl_set() function needs to be declared because socket.c
references it.

All of your visual scanning of the code is wasted if you don't
do something simple like an "allmodconfig" or "allyesconfig"
build to test whether your change is correct or not.

Don't leave that step for us, that's your responsibility.