linux-kernel - Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200911075715.4e1e5649@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 11 Sep 2020 07:57:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xie He <xie.he.0141@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lee Jones <lee.jones@...aro.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH net-next] net/socket.c: Remove an unused header file
 <linux/if_frad.h>

On Thu, 10 Sep 2020 23:07:20 -0700 Xie He wrote:
> This header file is not actually used in this file. Let's remove it.
> 
> Information about this header file:
> 
> This header file comes from the "Frame Relay" module at
>   drivers/net/wan/dlci.c
> 
> The "Frame Relay" module is used by only one hardware driver, at:
>   drivers/net/wan/sdla.c
> 
> Note that the "Frame Relay" module is different from and unrelated to the
> "HDLC Frame Relay" module at:
>   drivers/net/wan/hdlc_fr.c
> 
> I think maybe we can deprecate the "Frame Relay" module because we already
> have the (newer) "HDLC Frame Relay" module.
> 
> Signed-off-by: Xie He <xie.he.0141@...il.com>

net/socket.c:1032:6: warning: no previous prototype for ‘dlci_ioctl_set’ [-Wmissing-prototypes]
 1032 | void dlci_ioctl_set(int (*hook) (unsigned int, void __user *))
      |      ^~~~~~~~~~~~~~
net/socket.c:1032:6: warning: symbol 'dlci_ioctl_set' was not declared. Should it be static?