linux-kernel - Re: [PATCH 19/24] pthread_setname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c2150bc-d4df-e821-1717-6450540b6c71@gmail.com>
Date:   Fri, 11 Sep 2020 10:32:46 +0200
From:   Alejandro Colomar <colomar.6.4.3@...il.com>
To:     "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Cc:     linux-man@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/24] pthread_setname_np.3: ffix

Hi Michael,

The indentation in the original code was a bit weird (specifically, the 
'do {' part had one more indentation level than the closing '} while'), 
so I simply chose something nice.  See the original page, and if you 
think it's ok keep it, else find something nice :)

Cheers,

Alex

On 2020-09-11 09:58, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
> 
> On 9/10/20 11:13 PM, Alejandro Colomar wrote:
>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@...il.com>
>> ---
>>   man3/pthread_setname_np.3 | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> What's the rationale for this patch?
> 
> Thanks,
> 
> Michael
>>
>> diff --git a/man3/pthread_setname_np.3 b/man3/pthread_setname_np.3
>> index b206f66c0..4dc4960cd 100644
>> --- a/man3/pthread_setname_np.3
>> +++ b/man3/pthread_setname_np.3
>> @@ -164,8 +164,9 @@ THREADFOO
>>   
>>   #define NAMELEN 16
>>   
>> -#define errExitEN(en, msg) \e
>> -            do { errno = en; perror(msg); exit(EXIT_FAILURE); \e
>> +#define errExitEN(en, msg) do \e
>> +        { \
>> +            errno = en; perror(msg); exit(EXIT_FAILURE); \e
>>           } while (0)
>>   
>>   static void *
>>
> 
>