linux-kernel - Re: [PATCH 23/24] select_tut.2: Use MAX(a, b) from <sys/param.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e10294cf-e7fc-6ef4-55e9-c09ba30d995f@gmail.com>
Date:   Fri, 11 Sep 2020 10:46:26 +0200
From:   Alejandro Colomar <colomar.6.4.3@...il.com>
To:     "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Cc:     linux-man@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 23/24] select_tut.2: Use MAX(a, b) from <sys/param.h>

Hi Michael,

On 2020-09-11 09:54, Michael Kerrisk (man-pages) wrote:
> Hi Alex,
> 
> On 9/10/20 11:13 PM, Alejandro Colomar wrote:
>> Signed-off-by: Alejandro Colomar <colomar.6.4.3@...il.com>
> 
> I'm reluctant to apply this, because MAX() is not a standard
> macro. I suppose it may not be present on some other UNIX
> systems. You thoughts?

I know the BSDs have it; maybe not all of them (I don't know them all), 
but it is present at least in OpenBSD, libbsd, FreeBSD so I guess it's 
common enough.
For other UNIX systems, I have no idea.
Maybe there's some unicorn UNIX that doesn't have it... impossible to tell.

Cheers,

Alex