linux-kernel - Re: [PATCH] ubifs: setflags: Don't show error message when vfs_ioc_setflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvx1a7wGWJGhNvW5w3acGysEnuYbpJ_v=wOLpubB47=BKA@mail.gmail.com>
Date:   Sun, 13 Sep 2020 20:39:50 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     "zhangyi (F)" <yi.zhang@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mtd@...ts.infradead.org
Subject: Re: [PATCH] ubifs: setflags: Don't show error message when
 vfs_ioc_setflags_prepare() fails

On Sun, Aug 30, 2020 at 9:23 PM Richard Weinberger
<richard.weinberger@...il.com> wrote:
>
> On Fri, Aug 28, 2020 at 5:33 AM Zhihao Cheng <chengzhihao1@...wei.com> wrote:
> >
> > Following process will trigger ubifs_err:
> >   1. useradd -m freg                                        (Under root)
> >   2. cd /home/freg && mkdir mp                              (Under freg)
> >   3. mount -t ubifs /dev/ubi0_0 /home/freg/mp               (Under root)
> >   4. cd /home/freg && echo 123 > mp/a                       (Under root)
> >   5. cd mp && chown freg a && chgrp freg a && chmod 777 a   (Under root)
> >   6. chattr +i a                                            (Under freg)
> >
> > UBIFS error (ubi0:0 pid 1723): ubifs_ioctl [ubifs]: can't modify inode
> > 65 attributes
> > chattr: Operation not permitted while setting flags on a
> >
> > This is not an UBIFS problem, it was caused by task priviliage checking
> > on file operations. Remove error message printing from kernel just like
> > other filesystems (eg. ext4), since we already have enough information
> > from userspace tools.
> >
> > Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
> > ---
> >  fs/ubifs/ioctl.c | 1 -
> >  1 file changed, 1 deletion(-)
>
> Makes sense, thanks for fixing!

Applied to fixes.

-- 
Thanks,
//richard