linux-kernel - Re: [PATCH] ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvxOw1ZY9PoeuJNGaweFBTjoW3jAj2=TtF5wMkBm-dgh9A@mail.gmail.com>
Date:   Sun, 13 Sep 2020 20:42:34 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     "zhangyi (F)" <yi.zhang@...wei.com>, linux-mtd@...ts.infradead.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink >
 0' for host inode

On Mon, Aug 17, 2020 at 4:29 PM Zhihao Cheng <chengzhihao1@...wei.com> wrote:
>
> Changing xattr of a temp file will trigger following assertion failed
> and make ubifs turn into readonly filesystem:
>   ubifs_assert_failed [ubifs]: UBIFS assert failed: host->i_nlink > 0,
>   in fs/ubifs/journal.c:1801
>
> Reproducer:
>   1. fd = open(__O_TMPFILE)
>   2. fsetxattr(fd, key, value2, XATTR_CREATE)
>   3. fsetxattr(fd, key, value2, XATTR_REPLACE)
>
> Fix this by removing assertion 'nlink > 0' for host inode.
>
> Reported-by: Chengsong Ke <kechengsong@...wei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>

Applied to fixes, thanks!

-- 
Thanks,
//richard