linux-kernel - Re: [PATCH] dt-bindings: leds: common: Add mmc0 as default trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200914182010.GA4172388@bogus>
Date:   Mon, 14 Sep 2020 12:20:10 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: common: Add mmc0 as default trigger

On Sun, Aug 30, 2020 at 01:11:15PM +0200, Krzysztof Kozlowski wrote:
> MMC could be a default trigger so add a pattern to match it and fix
> dtbs_check warnings like:
> 
>   arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: leds: led2:linux,default-trigger:0:
>     'mmc0' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
>     From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml

The preference is to move from 'linux,default-trigger' to 'function' 
with some standardization of the names or use the trigger-source binding.

> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index a2a541bca73c..6b38f9f3792c 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -78,25 +78,26 @@ properties:
>        This parameter, if present, is a string defining the trigger assigned to
>        the LED.
>      $ref: /schemas/types.yaml#definitions/string
> -
> -    enum:
> -        # LED will act as a back-light, controlled by the framebuffer system
> -      - backlight
> -        # LED will turn on (but for leds-gpio see "default-state" property in
> -        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> -      - default-on
> -        # LED "double" flashes at a load average based rate
> -      - heartbeat
> -        # LED indicates disk activity
> -      - disk-activity
> -        # LED indicates IDE disk activity (deprecated), in new implementations
> -        # use "disk-activity"
> -      - ide-disk
> -        # LED flashes at a fixed, configurable rate
> -      - timer
> -        # LED alters the brightness for the specified duration with one software
> -        # timer (requires "led-pattern" property)
> -      - pattern
> +    oneOf:
> +      - enum:
> +            # LED will act as a back-light, controlled by the framebuffer system
> +          - backlight
> +            # LED will turn on (but for leds-gpio see "default-state" property in
> +            # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> +          - default-on
> +            # LED "double" flashes at a load average based rate
> +          - heartbeat
> +            # LED indicates disk activity
> +          - disk-activity
> +            # LED indicates IDE disk activity (deprecated), in new implementations
> +            # use "disk-activity"
> +          - ide-disk
> +            # LED flashes at a fixed, configurable rate
> +          - timer
> +            # LED alters the brightness for the specified duration with one software
> +            # timer (requires "led-pattern" property)
> +          - pattern
> +      - pattern: "^mmc[0-9]+$"
>  
>    led-pattern:
>      description: |
> -- 
> 2.17.1
>