linux-kernel - Re: [PATCH v10 14/24] coresight: allow funnel driver to be built as module

Open Source and information security mailing list archives

Message-ID: <20200914021659.GA22686@codeaurora.org>
Date:   Mon, 14 Sep 2020 10:17:00 +0800
From:   Tingwei Zhang <tingweiz@...eaurora.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     tingwei@...eaurora.org, mathieu.poirier@...aro.org,
        alexander.shishkin@...ux.intel.com, mike.leach@...aro.org,
        tsoni@...eaurora.org, saiprakash.ranjan@...eaurora.org,
        kim.phillips@....com, lkp@...el.com, jinlmao@...eaurora.org,
        gregkh@...uxfoundation.org, coresight@...ts.linaro.org,
        rdunlap@...radead.org, ykaukab@...e.de, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, leo.yan@...aro.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v10 14/24] coresight: allow funnel driver to be built as
 module

On Sun, Sep 13, 2020 at 09:24:52PM +0800, Suzuki K Poulose wrote:
> On 08/21/2020 04:44 AM, Tingwei Zhang wrote:
> >From: Kim Phillips <kim.phillips@....com>
> >
> >Allow to build coresight-funnel as module, for ease of development.
> >
> >- combine static and dynamic funnel init into single
> >   module_init/exit call
> >- add funnel_remove functions, for module unload
> >- add a MODULE_DEVICE_TABLE for autoloading on boot
> >
> >Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> >Cc: Leo Yan <leo.yan@...aro.org>
> >Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> >Cc: Randy Dunlap <rdunlap@...radead.org>
> >Cc: Suzuki K Poulose <Suzuki.Poulose@....com>
> >Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >Cc: Russell King <linux@...linux.org.uk>
> >Co-developed-by: Mian Yousaf Kaukab <ykaukab@...e.de>
> >Signed-off-by: Mian Yousaf Kaukab <ykaukab@...e.de>
> >Signed-off-by: Kim Phillips <kim.phillips@....com>
> >Signed-off-by: Tingwei Zhang <tingwei@...eaurora.org>
> >Reported-by: kernel test robot <lkp@...el.com>
> >Tested-by: Mike Leach <mike.leach@...aro.org>
> >Reviewed-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> >---
> >  .../hwtracing/coresight/coresight-funnel.c    | 64 ++++++++++++++++++-
> >  1 file changed, 62 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/hwtracing/coresight/coresight-funnel.c
> b/drivers/hwtracing/coresight/coresight-funnel.c
> >index 900690a9f7f0..07bc20391fac 100644
> >--- a/drivers/hwtracing/coresight/coresight-funnel.c
> >+++ b/drivers/hwtracing/coresight/coresight-funnel.c
> >@@ -274,6 +274,15 @@ static int funnel_probe(struct device *dev, struct
> resource *res)
> >  	return ret;
> >  }
> >+static int __exit funnel_remove(struct device *dev)
> >+{
> >+	struct funnel_drvdata *drvdata = dev_get_drvdata(dev);
> >+
> >+	coresight_unregister(drvdata->csdev);
> >+
> >+	return 0;
> >+}
> >+
> >  #ifdef CONFIG_PM
> >  static int funnel_runtime_suspend(struct device *dev)
> >  {
> >@@ -319,20 +328,32 @@ static int static_funnel_probe(struct
> platform_device *pdev)
> >  	return ret;
> >  }
> >+static int __exit static_funnel_remove(struct platform_device *pdev)
> >+{
> >+	funnel_remove(&pdev->dev);
> >+	pm_runtime_disable(&pdev->dev);
> >+	return 0;
> >+}
> >+
> >  static const struct of_device_id static_funnel_match[] = {
> >  	{.compatible = "arm,coresight-static-funnel"},
> >  	{}
> >  };
> >+MODULE_DEVICE_TABLE(of, static_funnel_match);
> >+
> >  #ifdef CONFIG_ACPI
> >  static const struct acpi_device_id static_funnel_ids[] = {
> >  	{"ARMHC9FE", 0},
> >  	{},
> >  };
> >+
> >+MODULE_DEVICE_TABLE(acpi, static_funnel_ids);
> >  #endif
> >  static struct platform_driver static_funnel_driver = {
> >  	.probe          = static_funnel_probe,
> >+	.remove          = static_funnel_remove,
> >  	.driver         = {
> >  		.name   = "coresight-static-funnel",
> >  		.of_match_table = static_funnel_match,
> 
> Sorry missed this. Please set the owner field here. With that :
> 
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>
>
Thanks, Suzuki. I'll add owner in v11.

Thanks,
Tingwei 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives