linux-kernel - Re: [PATCH v10 09/24] coresight: etm3x: allow etm3x to be built as a module

Open Source and information security mailing list archives

Date:   Mon, 14 Sep 2020 10:19:28 +0800
From:   Tingwei Zhang <tingweiz@...eaurora.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     tingwei@...eaurora.org, mathieu.poirier@...aro.org,
        alexander.shishkin@...ux.intel.com, mike.leach@...aro.org,
        tsoni@...eaurora.org, saiprakash.ranjan@...eaurora.org,
        kim.phillips@....com, jinlmao@...eaurora.org,
        gregkh@...uxfoundation.org, coresight@...ts.linaro.org,
        rdunlap@...radead.org, ykaukab@...e.de, linux@...linux.org.uk,
        linux-kernel@...r.kernel.org, leo.yan@...aro.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v10 09/24] coresight: etm3x: allow etm3x to be built as a
 module

On Sun, Sep 13, 2020 at 09:17:05PM +0800, Suzuki K Poulose wrote:
> On 08/21/2020 04:44 AM, Tingwei Zhang wrote:
> >From: Kim Phillips <kim.phillips@....com>
> >
> >Allow to build coresight-etm3x as a module, for ease of development.
> >
> >- Kconfig becomes a tristate, to allow =m
> >- append -core to source file name to allow module to
> >   be called coresight-etm3x by the Makefile
> >- add an etm_remove function, for module unload
> >- add a MODULE_DEVICE_TABLE for autoloading on boot
> >
> >Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> >Cc: Leo Yan <leo.yan@...aro.org>
> >Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> >Cc: Randy Dunlap <rdunlap@...radead.org>
> >Cc: Suzuki K Poulose <Suzuki.Poulose@....com>
> >Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >Cc: Russell King <linux@...linux.org.uk>
> >Signed-off-by: Kim Phillips <kim.phillips@....com>
> >Signed-off-by: Tingwei Zhang <tingwei@...eaurora.org>
> >Reviewed-by: Mike Leach <mike.leach@...aro.org>
> 
> 
> >diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> >similarity index 97%
> >rename from drivers/hwtracing/coresight/coresight-etm3x.c
> >rename to drivers/hwtracing/coresight/coresight-etm3x-core.c
> >index bf22dcfd3327..ba9c86497acb 100644
> >--- a/drivers/hwtracing/coresight/coresight-etm3x.c
> >+++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> >@@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev,
> const struct amba_id *id)
> >  	return ret;
> >  }
> >+static int __exit etm_remove(struct amba_device *adev)
> >+{
> >+	struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev);
> >+
> >+	etm_perf_symlink(drvdata->csdev, false);
> >+
> >+	if (--etm_count == 0) {
> >+
> cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING);
> >+		if (hp_online)
> >+			cpuhp_remove_state_nocalls(hp_online);
> >+	}
> >+
> >+	coresight_unregister(drvdata->csdev);
> >+
> >+	return 0;
> >+}
> >+
> 
> Don't we need to fix the races like we did for ETMv4 ?
> 
> Suzuki
> 
Yes, we need that.  Unfortunately, I don't have ETMv3 devie to verify the
change.  Mathieu has been very kind to offer his help to take care of
ETMv3.

Thanks,
Tingwei
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives