linux-kernel - [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Sep 2020 17:19:55 +0300
From:   Necip Fazil Yildiran <fazilyildiran@...il.com>
To:     nsekhar@...com
Cc:     geert+renesas@...der.be, bgolaszewski@...libre.com, arnd@...db.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        paul@...zz.com, jeho@...utexas.edu,
        Necip Fazil Yildiran <fazilyildiran@...il.com>
Subject: [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB

When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
in the following Kbuild warning:

WARNING: unmet direct dependencies detected for GPIO_PCF857X
  Depends on [n]: GPIOLIB [=n] && I2C [=y]
  Selected by [y]:
  - MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]

The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
GPIOLIB.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>
---
 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index e0cbcda6f087..3a6307d85828 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -130,6 +130,7 @@ config MACH_DAVINCI_DA830_EVM
 	bool "TI DA830/OMAP-L137/AM17x Reference Platform"
 	default ARCH_DAVINCI_DA830
 	depends on ARCH_DAVINCI_DA830
+	select GPIOLIB if I2C
 	select GPIO_PCF857X if I2C
 	help
 	  Say Y here to select the TI DA830/OMAP-L137/AM17x Evaluation Module.
-- 
2.25.1