linux-kernel - Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a04c933d-9642-c211-1e49-7f564019d6ab@ti.com>
Date:   Mon, 28 Sep 2020 23:43:08 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Necip Fazil Yildiran <fazilyildiran@...il.com>
CC:     <geert+renesas@...der.be>, <bgolaszewski@...libre.com>,
        <arnd@...db.de>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <paul@...zz.com>,
        <jeho@...utexas.edu>
Subject: Re: [PATCH] ARM: davinci: fix kconfig dependency warning when
 !GPIOLIB

On 14/09/20 7:49 PM, Necip Fazil Yildiran wrote:
> When MACH_DAVINCI_DA830_EVM is enabled and GPIOLIB is disabled, it results
> in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for GPIO_PCF857X
>   Depends on [n]: GPIOLIB [=n] && I2C [=y]
>   Selected by [y]:
>   - MACH_DAVINCI_DA830_EVM [=y] && ARCH_DAVINCI [=y] && ARCH_DAVINCI_DA830 [=y] && I2C [=y]
> 
> The reason is that MACH_DAVINCI_DA830_EVM selects GPIO_PCF857X without
> depending on or selecting GPIOLIB while GPIO_PCF857X is subordinate to
> GPIOLIB.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: 77316f057526 ("davinci: DA830/OMAP-L137 EVM: use runtime detection for UI card")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@...il.com>

Here too, I think changing to "imply GPIO_PCF857X if I2C" is better.

Thanks,
Sekhar