linux-kernel - Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJMnkt0=AKh36bCpsmkACHMoQbVyuh65NL4PXrvt4A+ag@mail.gmail.com>
Date:   Mon, 14 Sep 2020 08:36:07 -0600
From:   Rob Herring <robh@...nel.org>
To:     Qiang Zhao <qiang.zhao@....com>
Cc:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for nxp,rtc-2127.txt

On Mon, Sep 14, 2020 at 1:08 AM Qiang Zhao <qiang.zhao@....com> wrote:
>
> On Fri, Sep 11, 2020 at 22:03, Rob Herring <robh@...nel.org> wrote:
>
> > -----Original Message-----
> > From: Rob Herring <robh@...nel.org>
> > Sent: 2020年9月11日 22:03
> > To: Qiang Zhao <qiang.zhao@....com>
> > Cc: a.zummo@...ertech.it; alexandre.belloni@...tlin.com;
> > linux-rtc@...r.kernel.org; devicetree@...r.kernel.org;
> > linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for
> > nxp,rtc-2127.txt
> >
> > On Wed, Sep 9, 2020 at 9:16 PM Qiang Zhao <qiang.zhao@....com> wrote:
> > >
> > > On Thu, Sep 10, 2020 at 04:25AM, Rob Herring <robh@...nel.org> wrote:
> > > > -----Original Message-----
> > > > From: Rob Herring <robh@...nel.org>
> > > > Sent: 2020年9月10日 4:25
> > > > To: Qiang Zhao <qiang.zhao@....com>
> > > > Cc: a.zummo@...ertech.it; alexandre.belloni@...tlin.com;
> > > > linux-rtc@...r.kernel.org; devicetree@...r.kernel.org;
> > > > linux-kernel@...r.kernel.org
> > > > Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for
> > > > nxp,rtc-2127.txt
> > > >
> > > > On Thu, Aug 27, 2020 at 05:14:39PM +0800, Qiang Zhao wrote:
> > > > > From: Zhao Qiang <qiang.zhao@....com>
> > > > >
>
> Please help to review as below, if it is ok, I will send the new version patch. Thank you!
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> new file mode 100644
> index 0000000..809dd59
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: GPL-2.0

Dual license new bindings please:

(GPL-2.0-only OR BSD-2-Clause)

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/nxp,pcf2127.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PCF RTCs
> +
> +maintainers:
> +  - Qiang Zhao <qiang.zhao@....com>
> +
> +allOf:
> +  - $ref: "rtc.yaml#"
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nxp,pcf2127
> +      - nxp,pcf2129
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  no-watchdog:
> +    maxItems: 1

maxItems is for arrays. What's the type here? It should have a description too.

> +
> +  start-year: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +...
>
> >
> > Documentation/devicetree/writing-schema.rst and about 1000 examples in the
> > kernel tree.
> >
> > Rob