linux-kernel - RE: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in fec_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM8PR04MB7315343612D0F76F6D6EB8CAFF230@AM8PR04MB7315.eurprd04.prod.outlook.com>
Date:   Mon, 14 Sep 2020 14:35:38 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Zhang Changzhong <zhangchangzhong@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] net: fec: ptp: remove unused variable 'ns' in
 fec_time_keep()

From: Zhang Changzhong <zhangchangzhong@...wei.com> Sent: Monday, September 14, 2020 9:14 PM
> Fixes the following W=1 kernel build warning(s):
> 
> drivers/net/ethernet/freescale/fec_ptp.c:523:6: warning:
>  variable 'ns' set but not used [-Wunused-but-set-variable]
>   523 |  u64 ns;
>       |      ^~
> 
> After commit 6605b730c061 ("FEC: Add time stamping code and a PTP
> hardware clock"), variable 'ns' is never used in fec_time_keep(), so removing it
> to avoid build warning.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@...wei.com>

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/net/ethernet/freescale/fec_ptp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index a0c1f44..0405a39 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -520,13 +520,12 @@ static void fec_time_keep(struct work_struct *work)
> {
>  	struct delayed_work *dwork = to_delayed_work(work);
>  	struct fec_enet_private *fep = container_of(dwork, struct
> fec_enet_private, time_keep);
> -	u64 ns;
>  	unsigned long flags;
> 
>  	mutex_lock(&fep->ptp_clk_mutex);
>  	if (fep->ptp_clk_on) {
>  		spin_lock_irqsave(&fep->tmreg_lock, flags);
> -		ns = timecounter_read(&fep->tc);
> +		timecounter_read(&fep->tc);
>  		spin_unlock_irqrestore(&fep->tmreg_lock, flags);
>  	}
>  	mutex_unlock(&fep->ptp_clk_mutex);
> --
> 2.9.5