linux-kernel - Re: [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200914164348.pfgl3u6l5ijgb2jo@hpe.com>
Date:   Mon, 14 Sep 2020 11:44:30 -0500
From:   Russ Anderson <rja@....com>
To:     Alex Kluver <kluveralex@...il.com>
Cc:     linux-edac@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, ardb@...nel.org, mchehab@...nel.org,
        bp@...en8.de, russ.anderson@....com, dimitri.sivanich@....com,
        kluveralex@...il.com
Subject: Re: [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates

On Wed, Aug 19, 2020 at 09:35:42AM -0500, Alex Kluver wrote:
> The UEFI Specification v2.8, Table 299, Memory Error Record has
> several changes from previous versions. Bits 18 through 21 have been
> added to the memory validation bits to include an extended version
> of row, an option to print bank address and group separately, and chip id.
> These patches implement bits 18 through 21 into the Memory Error Record.
> 
> Change reserved field to extended field in cper_sec_mem_err structure
> and added the extended field to the cper_mem_err_compact structure.
> 
> Print correct versions of row, bank, and chip ID.

Are there any community comment on this patch set?
Questions/comments/concerns?

Thanks.

> ---
> v1 -> v2:
>    * Add static inline cper_get_mem_extension to make
>      it more readable, as suggested by Borislav Petkov
> 
>    * Add second patch for bank field, bank group, and chip id.
> ---
> Alex Kluver (2):
>   edac,ghes,cper: Add Row Extension to Memory Error Record
>   cper,edac,efi: Memory Error Record: bank group/address and chip id
> 
>  drivers/edac/ghes_edac.c    | 17 +++++++++++++++--
>  drivers/firmware/efi/cper.c | 18 ++++++++++++++++--
>  include/linux/cper.h        | 24 ++++++++++++++++++++++--
>  3 files changed, 53 insertions(+), 6 deletions(-)
> 
> -- 
> 2.26.2
> 

-- 
Russ Anderson,  SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI)  rja@....com