linux-kernel - Re: [PATCH v2 2/2] cper,edac,efi: Memory Error Record: bank group/address and chip id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 18:36:13 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Alex Kluver <alex.kluver@....com>
Cc:     linux-edac@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, ardb@...nel.org, mchehab@...nel.org,
        russ.anderson@....com, dimitri.sivanich@....com,
        kluveralex@...il.com
Subject: Re: [PATCH v2 2/2] cper,edac,efi: Memory Error Record: bank
 group/address and chip id

On Wed, Aug 19, 2020 at 09:35:44AM -0500, Alex Kluver wrote:
> Updates to the UEFI 2.8 Memory Error Record allow splitting the bank field
> into bank address and bank group, and using the last 3 bits of the extended
> field as a chip identifier.
> 
> When needed, print correct version of bank field, bank group, and chip
> identification
> 
> Based on UEFI 2.8 Table 299. Memory Error Record

Whoever commits this - those last two sentences need fullstops.

> Reviewed-by: Steve Wahl <steve.wahl@....com>
> Reviewed-by: Kyle Meyer <kyle.meyer@....com>
> Reviewed-by: Russ Anderson <russ.anderson@....com>
> Signed-off-by: Alex Kluver <alex.kluver@....com>
> ---
> 
> v1 -> v2:
>    * Add static inline cper_get_mem_extension() to make it
>     more readable, as suggested by Borislav Petkov.
> 
>    * Add second patch for bank field, bank group, and chip id.
> 
> ---
>  drivers/edac/ghes_edac.c    | 9 +++++++++
>  drivers/firmware/efi/cper.c | 9 +++++++++
>  include/linux/cper.h        | 8 ++++++++
>  3 files changed, 26 insertions(+)

For the EDAC bits:

Acked-by: Borislav Petkov <bp@...e.de>

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette