linux-kernel - Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200915163312.GO14436@zn.tnic>
Date:   Tue, 15 Sep 2020 18:33:12 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Alex Kluver <alex.kluver@....com>
Cc:     linux-edac@...r.kernel.org, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, ardb@...nel.org, mchehab@...nel.org,
        russ.anderson@....com, dimitri.sivanich@....com,
        kluveralex@...il.com
Subject: Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error
 Record

On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote:
> Memory errors could be printed with incorrect row values since the DIMM
> size has outgrown the 16 bit row field in the CPER structure. UEFI
> Specification Version 2.8 has increased the size of row by allowing it to
> use the first 2 bits from a previously reserved space within the structure.
> 
> When needed, add the extension bits to the row value printed.
> 
> Based on UEFI 2.8 Table 299. Memory Error Record
> 
> Reviewed-by: Kyle Meyer <kyle.meyer@....com>
> Reviewed-by: Steve Wahl <steve.wahl@....com>
> Tested-by: Russ Anderson <russ.anderson@....com>
> Signed-off-by: Alex Kluver <alex.kluver@....com>
> ---
> 
> v1 -> v2:
>    * Add static inline cper_get_mem_extension() to make it 
>     more readable, as suggested by Borislav Petkov.
> 
>    * Add second patch for bank field, bank group, and chip id.
> 
> ---
>  drivers/edac/ghes_edac.c    |  8 ++++++--
>  drivers/firmware/efi/cper.c |  9 +++++++--
>  include/linux/cper.h        | 16 ++++++++++++++--
>  3 files changed, 27 insertions(+), 6 deletions(-)

For the EDAC bits:

Acked-by: Borislav Petkov <bp@...e.de>

Also, I could take both through the EDAC tree, if people prefer.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette