[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <yq11rj267ij.fsf@ca-mkp.ca.oracle.com>
Date: Tue, 15 Sep 2020 17:44:00 -0400
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc: <linuxdrivers@...otech.com>, <jejb@...ux.ibm.com>,
<martin.petersen@...cle.com>, <linux-scsi@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: esas2r: prevent a potential NULL dereference in
esas2r_probe()
Jing,
> esas2r_probe() calls scsi_host_put() in an error path. However,
> esas2r_log_dev() may hit a potential NULL dereference. So use NUll instead.
Wouldn't it be better to move the scsi_host_put() call after the error
message?
--
Martin K. Petersen Oracle Linux Engineering
Powered by blists - more mailing lists