linux-kernel - Re: [PATCH] media: Kconfig: Update help description VIDEO_RENESAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200915213008.GB28219@pendragon.ideasonboard.com>
Date:   Wed, 16 Sep 2020 00:30:08 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>
Subject: Re: [PATCH] media: Kconfig: Update help description
 VIDEO_RENESAS_FCP config

On Wed, Sep 16, 2020 at 12:26:08AM +0300, Laurent Pinchart wrote:
> Hi Prabhakar,
> 
> Thank you for the patch.
> 
> On Fri, Sep 11, 2020 at 11:10:46AM +0100, Lad Prabhakar wrote:
> > rcar-fcp driver is also used on Renesas RZ/G2 SoC's, update the same
> 
> I'm not sure what you mean by "the same" here. I'd propose
> 
> The rcar_dw_hdmi driver is also used on Renesas RZ/G2 SoCs. Update the
> Kconfig entry description to reflect this.

And this was meant to be sent as a review of the DRM_RCAR_DW_HDMI patch
:-S For this patch, you could write

"The rcar-fcp driver is also used on Renesas RZ/G2 SoCs. Update the
Kconfig entry description to reflect this."

I would also replace the subject line with

"media: rcar-fcp: Update description for VIDEO_RENESAS_FCP Kconfig entry"

> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> 
> If you're fine with that, there's no need to resubmit the patch.
> 
> > to reflect help description for VIDEO_RENESAS_FCP config.
> > 
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@...esas.com>
> > ---
> >  drivers/media/platform/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> > index bbf32086b607..a5716e9f463a 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -426,8 +426,8 @@ config VIDEO_RENESAS_FCP
> >  	help
> >  	  This is a driver for the Renesas Frame Compression Processor (FCP).
> >  	  The FCP is a companion module of video processing modules in the
> > -	  Renesas R-Car Gen3 SoCs. It handles memory access for the codec,
> > -	  VSP and FDP modules.
> > +	  Renesas R-Car Gen3 and RZ/G2 SoCs. It handles memory access for
> > +	  the codec, VSP and FDP modules.
> >  
> >  	  To compile this driver as a module, choose M here: the module
> >  	  will be called rcar-fcp.

-- 
Regards,

Laurent Pinchart