linux-kernel - RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 15 Sep 2020 09:11:54 +0900
From:   Daejun Park <daejun7.park@...sung.com>
To:     "avri.altman" <avri.altman@....com>, jejb <jejb@...ux.ibm.com>,
        "martin.petersen" <martin.petersen@...cle.com>,
        asutoshd <asutoshd@...eaurora.org>, beanhuo <beanhuo@...ron.com>,
        "stanley.chu" <stanley.chu@...iatek.com>,
        cang <cang@...eaurora.org>, bvanassche <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
CC:     linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Adel Choi <adel.choi@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>
Subject: RE: [PATCH] scsi: ufs: Fix NOP OUT timeout value

> In some Samsung UFS devices, there is some booting fail issue with
> low-power UFS device. The reason of this issue is the UFS device has a
> little bit longer latency for NOP OUT response. It causes booting fail
> because NOP OUT command is issued during initialization to check whether
> the device transport protocol is ready or not. This issue is resolved by
> releasing NOP_OUT_TIMEOUT value.
> 
> NOP_OUT_TIMEOUT: 30ms -> 50ms
> 
> Signed-off-by: Daejun Park <daejun7.park@...sung.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 06e2439d523c..5cbd0e9e4ef8 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -36,8 +36,8 @@
>  
>  /* NOP OUT retries waiting for NOP IN response */
>  #define NOP_OUT_RETRIES    10
> -/* Timeout after 30 msecs if NOP OUT hangs without response */
> -#define NOP_OUT_TIMEOUT    30 /* msecs */
> +/* Timeout after 50 msecs if NOP OUT hangs without response */
> +#define NOP_OUT_TIMEOUT    50 /* msecs */
>  
>  /* Query request retries */
>  #define QUERY_REQ_RETRIES 3
> -- 
> 2.17.1

Hello,

Just a gentle reminder that I'd like some feedback.
Any suggestions here?

Thanks,
Daejun