linux-kernel - Re: [PATCH] perf vendor events amd: remove trailing comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADJK47PjKYCZiZ72oKnYnx2OPfOZXUzDdUD9m3yKJTpdpicAxA@mail.gmail.com>
Date:   Mon, 14 Sep 2020 20:33:39 -0400
From:   Henry Burns <henrywolfeburns@...il.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Kim Phillips <kim.phillips@....com>,
        Vijay Thakkar <vijaythakkar@...com>,
        Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf vendor events amd: remove trailing comma

> > amdzen2/core.json had a trailing comma on the x_ret_fus_brnch_inst
> > event. Since that goes against the JSON standard, lets remove it.
>
> is this the only case in all the .json files we have in
> tools/perf/pmu-events/?

I just searched the  pmu-events/arch/ folder, and found one other instance in
amdzen1. I'll send an updated patch now.
>
> - Arnaldo
>
> > Signed-off-by: Henry Burns <henrywolfeburns@...il.com>
> > ---
> >  tools/perf/pmu-events/arch/x86/amdzen2/core.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/pmu-events/arch/x86/amdzen2/core.json b/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> > index de89e5a44ff1..4b75183da94a 100644
> > --- a/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> > +++ b/tools/perf/pmu-events/arch/x86/amdzen2/core.json
> > @@ -125,6 +125,6 @@
> >    {
> >      "EventName": "ex_ret_fus_brnch_inst",
> >      "EventCode": "0x1d0",
> > -    "BriefDescription": "Retired Fused Instructions. The number of fuse-branch instructions retired per cycle. The number of events logged per cycle can vary from 0-8.",
> > +    "BriefDescription": "Retired Fused Instructions. The number of fuse-branch instructions retired per cycle. The number of events logged per cycle can vary from 0-8."
> >    }
> >  ]
> > --
> > 2.25.1
> >
>
> --
>
> - Arnaldo