linux-kernel - Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200915174855.822d866316948aadb8193e9b@linux-foundation.org>
Date:   Tue, 15 Sep 2020 17:48:55 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     <yanfei.xu@...driver.com>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be
 'unsigned long'

On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@...driver.com> wrote:

> From: Yanfei Xu <yanfei.xu@...driver.com>
> 
> try_to_free_pages returns the number of pages reclaimed, and the type of
> returns is 'unsigned long'. So we should use a matched type for storing
> it.
> 

__perform_reclaim() returns an int, so this change is fairly pointless.

However __perform_reclaim()'s single caller expects it to return
unsigned long, so including that change in this patch would make more
sense.