linux-kernel - Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d7dde64-826d-e449-0ca3-6521619cdf32@windriver.com>
Date:   Wed, 16 Sep 2020 09:56:43 +0800
From:   "Xu, Yanfei" <yanfei.xu@...driver.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be
 'unsigned long'



On 9/16/20 8:48 AM, Andrew Morton wrote:
> On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@...driver.com> wrote:
> 
>> From: Yanfei Xu <yanfei.xu@...driver.com>
>>
>> try_to_free_pages returns the number of pages reclaimed, and the type of
>> returns is 'unsigned long'. So we should use a matched type for storing
>> it.
>>
> 
> __perform_reclaim() returns an int, so this change is fairly pointless.
> 
> However __perform_reclaim()'s single caller expects it to return
> unsigned long, so including that change in this patch would make more
> sense.
> 
Yeah, thanks for reminding. I will add that and send a v2. :)

Regards,
Yanfei