linux-kernel - Re: [PATCH] fork: Use helper function mapping_allow_writable() in dup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3eaffcde4b28478483cd24154fc04836@huawei.com>
Date:   Wed, 16 Sep 2020 01:39:55 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Christian Brauner <christian.brauner@...ntu.com>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "christian@...lner.me" <christian@...lner.me>,
        "surenb@...gle.com" <surenb@...gle.com>,
        "areber@...hat.com" <areber@...hat.com>,
        "shakeelb@...gle.com" <shakeelb@...gle.com>,
        "cyphar@...har.com" <cyphar@...har.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fork: Use helper function mapping_allow_writable() in
 dup_mmap()

Christian Brauner <christian.brauner@...ntu.com> wrote:
> On Sun, Sep 13, 2020 at 05:24:15AM -0400, Miaohe Lin wrote:
>> Use helper function mapping_allow_writable() to atomic_inc i_mmap_writable.
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
>> ---
>
>Hey Miaohe,
>
>Thanks for the patch!
>Per se there's nothing against using a proper helper when it exists.
>But it has already been pointed out that this needs a proper commit message with more rationale. But I'm otherwise happy to take this.
>

Many thanks for your reply.
Eric have kindly pointed this out. I think I should provide a proper commit message with more rationale in v2.
Thanks again.

>Thanks!
>Christian