linux-kernel - Re: [PATCH] soc: qcom: apr: Fixup the error displayed on lookup failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200916063416.GM142621@kroah.com>
Date:   Wed, 16 Sep 2020 08:34:16 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sibi Sankar <sibis@...eaurora.org>
Cc:     bjorn.andersson@...aro.org, agross@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        srinivas.kandagatla@...aro.org, stable@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: apr: Fixup the error displayed on lookup
 failure

On Tue, Sep 15, 2020 at 09:12:32PM +0530, Sibi Sankar wrote:
> APR client incorrectly prints out "ret" variable on pdr_add_lookup failure,
> it should be printing the error value returned by the lookup instead.
> 
> Fixes: 8347356626028 ("soc: qcom: apr: Add avs/audio tracking functionality")
> Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
> ---
>  drivers/soc/qcom/apr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/apr.c b/drivers/soc/qcom/apr.c
> index 1f35b097c6356..7abfc8c4fdc72 100644
> --- a/drivers/soc/qcom/apr.c
> +++ b/drivers/soc/qcom/apr.c
> @@ -328,7 +328,7 @@ static int of_apr_add_pd_lookups(struct device *dev)
>  
>  		pds = pdr_add_lookup(apr->pdr, service_name, service_path);
>  		if (IS_ERR(pds) && PTR_ERR(pds) != -EALREADY) {
> -			dev_err(dev, "pdr add lookup failed: %d\n", ret);
> +			dev_err(dev, "pdr add lookup failed: %ld\n", PTR_ERR(pds));
>  			return PTR_ERR(pds);
>  		}
>  	}
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>