linux-kernel - Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75262d3f-eeb6-5531-a93d-85376236774a@linux.alibaba.com>
Date:   Thu, 17 Sep 2020 13:31:13 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Xiaoliang Pang <dawning.pang@...il.com>, mchehab@...nel.org,
        sakari.ailus@...ux.intel.com, gregkh@...uxfoundation.org
Cc:     alexander.deucher@....com, evan.quan@....com,
        christian.koenig@....com, linux-media@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] atomisp:pci/runtime/queue: modify the return error
 value

LGTM.

Reviewed-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>

On 9/17/20 11:44 AM, Xiaoliang Pang wrote:
> modify the return error value is -EDOM
> 
> Fixes: 2cac05dee6e30("drm/amd/powerplay: add the hw manager for vega12 (v4)")
> Cc: Evan Quan <evan.quan@....com>
> Signed-off-by: Xiaoliang Pang <dawning.pang@...il.com>
> ---
>   .../staging/media/atomisp/pci/runtime/queue/src/queue_access.c  | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> index fdca743c4ab7..424e7a15a389 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue_access.c
> @@ -44,7 +44,7 @@ int ia_css_queue_load(
>   				   the value as zero. This causes division by 0
>   				   exception as the size is used in a modular
>   				   division operation. */
> -				return EDOM;
> +				return -EDOM;
>   			}
>   		}
>   
>