linux-kernel - Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d4c2521-338a-8bce-46a7-b48818ddad66@oracle.com>
Date:   Thu, 17 Sep 2020 09:47:24 +0800
From:   Anand Jain <anand.jain@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>, clm@...com,
        josef@...icpanda.com, dsterba@...e.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] btrfs: Make btrfs_sysfs_add_fs_devices static




On 16/9/20 10:26 pm, YueHaibing wrote:
> Fix sparse warning:
> 
> fs/btrfs/sysfs.c:1386:5: warning:
>   symbol 'btrfs_sysfs_add_fs_devices' was not declared. Should it be static?


  misc-next branch has it declared static. It was fixed later.

Thanks, Anand


> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   fs/btrfs/sysfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
> index e7b0e10685d9..279d9262b676 100644
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -1383,7 +1383,7 @@ int btrfs_sysfs_add_device(struct btrfs_device *device)
>   	return ret;
>   }
>   
> -int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
> +static int btrfs_sysfs_add_fs_devices(struct btrfs_fs_devices *fs_devices)
>   {
>   	int ret;
>   	struct btrfs_device *device;
>