linux-kernel - Re: [PATCH v2 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add the Amlogic AXG Families USB Glue Bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d411aaba-389d-3200-1370-922a071e53d9@baylibre.com>
Date:   Thu, 17 Sep 2020 09:02:29 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     khilman@...libre.com, martin.blumenstingl@...glemail.com,
        devicetree@...r.kernel.org
Cc:     linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: usb: amlogic,meson-g12a-usb-ctrl: add
 the Amlogic AXG Families USB Glue Bindings

On 17/09/2020 08:59, Neil Armstrong wrote:
> The Amlogic AXG is close to the GXL Glue but with a single OTG PHY.
> 
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> Reviewed-by: Kevin Hilman <khilman@...libre.com>
> Acked-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>

Forgot:
Reviewed-by: Rob Herring <robh@...nel.org>

Neil

> ---
>  .../usb/amlogic,meson-g12a-usb-ctrl.yaml      | 22 ++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> index 5b04a7dfa018..c0058332b967 100644
> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml
> @@ -25,13 +25,14 @@ description: |
>    The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in
>    host-only mode.
>  
> -  The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY.
> +  The Amlogic GXL, GXM & AXG SoCs doesn't embed an USB3 PHY.
>  
>  properties:
>    compatible:
>      enum:
>        - amlogic,meson-gxl-usb-ctrl
>        - amlogic,meson-gxm-usb-ctrl
> +      - amlogic,meson-axg-usb-ctrl
>        - amlogic,meson-g12a-usb-ctrl
>        - amlogic,meson-a1-usb-ctrl
>  
> @@ -151,6 +152,25 @@ allOf:
>  
>        required:
>          - clock-names
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - amlogic,meson-axg-usb-ctrl
> +
> +    then:
> +      properties:
> +        phy-names:
> +          items:
> +            - const: usb2-phy1 # USB2 PHY1 if USBOTG_B port is used
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          items:
> +            - const: usb_ctrl
> +            - const: ddr
> +      required:
> +        - clock-names
>    - if:
>        properties:
>          compatible:
>