linux-kernel - Re: [PATCH] objtool: ignore unreachable trap after call to noreturn functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200918154840.h3xbspb5jq7zw755@treble>
Date:   Fri, 18 Sep 2020 10:51:43 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Ilie Halip <ilie.halip@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Rong Chen <rong.a.chen@...el.com>,
        Marco Elver <elver@...gle.com>,
        Philip Li <philip.li@...el.com>,
        Borislav Petkov <bp@...en8.de>,
        kasan-dev <kasan-dev@...glegroups.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH] objtool: ignore unreachable trap after call to noreturn
 functions

On Fri, Sep 18, 2020 at 08:35:40AM +0300, Ilie Halip wrote:
> > The patch looks good to me.  Which versions of Clang do the trap after
> > noreturn call?  It would be good to have that in the commit message.
> 
> I omitted this because it happens with all versions of clang that are
> supported for building the kernel. clang-9 is the oldest version that
> could build the mainline x86_64 kernel right now, and it has the same
> behavior.

Ok.  It should at least mention that this is a Clang-specific thing,
since GCC's version of UBSAN_TRAP doesn't do it.

> Should I send a v2 with this info?

Yes, please.

-- 
Josh