linux-kernel - Re: [PATCH -next] HID: intel-ish-hid: simplify the return expression of ishtp_bus_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca452e8f61c2e828bc3ec2dc5993f87d251e5e38.camel@intel.com>
Date:   Mon, 21 Sep 2020 14:45:04 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "jikos@...nel.org" <jikos@...nel.org>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        "miaoqinglang@...wei.com" <miaoqinglang@...wei.com>
CC:     "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] HID: intel-ish-hid: simplify the return expression
 of ishtp_bus_remove_device()

On Mon, 2020-09-21 at 21:10 +0800, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/hid/intel-ish-hid/ishtp/bus.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index c47c3328a..bba29cd36 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -502,8 +502,6 @@ static void ishtp_bus_remove_device(struct
> ishtp_cl_device *device)
>  int ishtp_cl_driver_register(struct ishtp_cl_driver *driver,
>  			     struct module *owner)
>  {
> -	int err;
> -
>  	if (!ishtp_device_ready)
>  		return -ENODEV;
>  
> @@ -511,11 +509,7 @@ int ishtp_cl_driver_register(struct
> ishtp_cl_driver *driver,
>  	driver->driver.owner = owner;
>  	driver->driver.bus = &ishtp_cl_bus_type;
>  
> -	err = driver_register(&driver->driver);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return driver_register(&driver->driver);
>  }
>  EXPORT_SYMBOL(ishtp_cl_driver_register);
>