linux-kernel - Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200921190025.GI4792@sirena.org.uk>
Date:   Mon, 21 Sep 2020 20:00:25 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Aswath Govindraju <a-govindraju@...com>
Cc:     Sekhar Nori <nsekhar@...com>, Vignesh R <vigneshr@...com>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll_timeout()"

On Mon, Sep 21, 2020 at 07:56:38PM +0100, Mark Brown wrote:
> On Thu, Sep 10, 2020 at 05:56:24PM +0530, Aswath Govindraju wrote:
> > This reverts commit 13d515c796adc49a49b0cd2212ccd7f43a37fc5a.
> > 
> > The amount of time spent polling for the MCSPI_CHSTAT bits to be set on
> > AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

Oh, and also:

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)