linux-kernel - Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160073317818.6418.1953400870521393245.b4-ty@kernel.org>
Date:   Tue, 22 Sep 2020 01:06:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Aswath Govindraju <a-govindraju@...com>
Cc:     Vignesh R <vigneshr@...com>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH] Revert "spi: omap2-mcspi: Switch to readl_poll_timeout()"

On Thu, 10 Sep 2020 17:56:24 +0530, Aswath Govindraju wrote:
> This reverts commit 13d515c796adc49a49b0cd2212ccd7f43a37fc5a.
> 
> The amount of time spent polling for the MCSPI_CHSTAT bits to be set on
> AM335x-icev2 platform is less than 1us (about 0.6us) in most cases, with
> or without using DMA. So, in most cases the function need not sleep.
> Also, setting the sleep_usecs to zero would not be optimal here because
> ktime_add_us() used in readl_poll_timeout() is slower compared to the
> direct addition used after the revert. So, it is sub-optimal to use
> readl_poll_timeout in this case.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: omap2-mcspi: Improve performance waiting for CHSTAT
      commit: 7b1d96813317358312440d0d07abbfbeb0ef8d22

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark