linux-kernel - Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <272066d2-35db-0441-a49d-9315894ae674@st.com>
Date:   Mon, 21 Sep 2020 11:26:44 +0200
From:   Ludovic BARRE <ludovic.barre@...com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Rob Herring <robh+dt@...nel.org>
CC:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH] irqchip/stm32: fix return value of
 stm32_exti_h_set_affinity

Hi Marc

Just a gentleman ping about this patch.
I verified, you could always apply this patch on linux master branch.

Regards
Ludo

Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit :
> exti hardware point of view, there is no specific action on set_affinity.
> So the affinity must be forwarded to parent if there is a
> descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
> 
> Signed-off-by: Ludovic Barre <ludovic.barre@...com>
> ---
>   drivers/irqchip/irq-stm32-exti.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index faa8482c8246..1a0a60ee7140 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
>   	if (d->parent_data->chip)
>   		return irq_chip_set_affinity_parent(d, dest, force);
>   
> -	return -EINVAL;
> +	return IRQ_SET_MASK_OK_DONE;
>   }
>   
>   static int __maybe_unused stm32_exti_h_suspend(void)
>