[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9d02d4c6e1c44493af80e992ef911eb6@HQMAIL111.nvidia.com>
Date: Mon, 21 Sep 2020 10:19:37 +0000
From: Thierry Reding <treding@...dia.com>
To: Dmitry Osipenko <digetx@...il.com>
CC: Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Laxman Dewangan <ldewangan@...dia.com>,
Wolfram Sang <wsa@...-dreams.de>,
Michał Mirosław <mirq-linux@...e.qmqm.pl>,
Andy Shevchenko <andy.shevchenko@...il.com>,
<linux-i2c@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 17/34] i2c: tegra: Remove outdated barrier()
On Wed, 09 Sep 2020 01:39:49 +0300, Dmitry Osipenko wrote:
> The barrier() was intended to reduce possibility of racing with the
> interrupt handler, but driver's code evolved significantly and today's
> driver enables interrupt only when it waits for completion notification.
> Hence barrier() has no good use anymore, let's remove it.
>
> Reviewed-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> Acked-by: Thierry Reding <treding@...dia.com>
> ---
> drivers/i2c/busses/i2c-tegra.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Tested-by: Thierry Reding <treding@...dia.com>
Powered by blists - more mailing lists