linux-kernel - Re: [PATCH 05/42] mfd: axp20x: use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VecLojCKW1ckVJvW_cjUek14QxpS=JZH0D2P6jVHBMGqQ@mail.gmail.com>
Date:   Tue, 22 Sep 2020 11:21:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Support Opensource <support.opensource@...semi.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Milo Kim <milo.kim@...com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Tony Lindgren <tony@...mide.com>,
        patches@...nsource.cirrus.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-samsung-soc@...r.kernel.org,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 05/42] mfd: axp20x: use PLATFORM_DEVID_NONE

On Mon, Sep 21, 2020 at 11:52 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/mfd/axp20x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index aa59496e4376..70aa538a4b64 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -967,7 +967,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>                 return ret;
>         }
>
> -       ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> +       ret = mfd_add_devices(axp20x->dev, PLATFORM_DEVID_NONE, axp20x->cells,
>                               axp20x->nr_cells, NULL, 0, NULL);
>
>         if (ret) {
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko