linux-kernel - Re: [PATCH 10/42] mfd: intel_msic: use PLATFORM_DEVID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Veb3NAS+GekwQvL2_Y-jRbiJNM6W4JhH6o3R8GjSC8uww@mail.gmail.com>
Date:   Tue, 22 Sep 2020 11:22:28 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Support Opensource <support.opensource@...semi.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Milo Kim <milo.kim@...com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Tony Lindgren <tony@...mide.com>,
        patches@...nsource.cirrus.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-samsung-soc@...r.kernel.org,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 10/42] mfd: intel_msic: use PLATFORM_DEVID_NONE

On Mon, Sep 21, 2020 at 11:54 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
>  - it brings some meaning,
>  - it might point attention why auto device ID was not used.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/mfd/intel_msic.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/intel_msic.c b/drivers/mfd/intel_msic.c
> index bb24c2a07900..e9944a81dc44 100644
> --- a/drivers/mfd/intel_msic.c
> +++ b/drivers/mfd/intel_msic.c
> @@ -317,8 +317,9 @@ static int intel_msic_init_devices(struct intel_msic *msic)
>                 if (!pdata->irq[i])
>                         continue;
>
> -               ret = mfd_add_devices(&pdev->dev, -1, &msic_devs[i], 1, NULL,
> -                                     pdata->irq[i], NULL);
> +               ret = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> +                                     &msic_devs[i], 1, NULL, pdata->irq[i],
> +                                     NULL);
>                 if (ret)
>                         goto fail;
>         }
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko