linux-kernel - Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200922110825.GN4792@sirena.org.uk>
Date:   Tue, 22 Sep 2020 12:08:25 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Srinivasa Rao Mandadapu <srivasam@...eaurora.org>,
        agross@...nel.org, bjorn.andersson@...aro.org, lgirdwood@...il.com,
        robh+dt@...nel.org, plai@...eaurora.org, bgoswami@...eaurora.org,
        perex@...ex.cz, tiwai@...e.com, rohitkr@...eaurora.org,
        linux-arm-msm@...r.kernel.org, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        V Sujith Kumar Reddy <vsujithk@...eaurora.org>
Subject: Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

On Mon, Sep 21, 2020 at 10:20:22PM +0100, Srinivas Kandagatla wrote:
> On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote:

> > -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif");

> Index is always preferred over name w.r.t device tree bindings, so lets
> stick with that for now!

It is?  That's not usually the case...

> Unless you have any strong reason to lookup resource by name?

Looking things up by name tends to make the DT easier to read (since
things are named).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)