linux-kernel - Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Sep 2020 23:13:05 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Andrew Oakley <andrew@...akley.name>,
        Chris Boyle <chris@...le.name>,
        "moderated list:SOUND" <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in
 volume control"


> On Sep 21, 2020, at 16:40, Takashi Iwai <tiwai@...e.de> wrote:
> 
> On Tue, 15 Sep 2020 12:39:23 +0200,
> Kai-Heng Feng wrote:
>> 
>> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
>> 
>> According to Realtek, volume FU works for line-in.
>> 
>> I can confirm volume control works after device firmware is updated.
> 
> A slight concern is what happens if you apply this change to the
> device before the firmware update.

The desktop that equips with the USB audio device hasn't released to the market yet, so I am not really worried about this.

> 
> Also, after this revert, does the mixer control appear properly?

Yes it does.

Kai-Heng

> 
> 
> thanks,
> 
> Takashi
> 
>> 
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
>> ---
>> sound/usb/mixer_maps.c | 1 -
>> 1 file changed, 1 deletion(-)
>> 
>> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
>> index 5b43e9e40e49..c369c81e74c4 100644
>> --- a/sound/usb/mixer_maps.c
>> +++ b/sound/usb/mixer_maps.c
>> @@ -371,7 +371,6 @@ static const struct usbmix_name_map asus_rog_map[] = {
>> };
>> 
>> static const struct usbmix_name_map lenovo_p620_rear_map[] = {
>> -	{ 19, NULL, 2 }, /* FU, Volume */
>> 	{ 19, NULL, 12 }, /* FU, Input Gain Pad */
>> 	{}
>> };
>> -- 
>> 2.17.1
>>