linux-kernel - Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hd02dyh8d.wl-tiwai@suse.de>
Date:   Tue, 22 Sep 2020 17:16:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Andrew Oakley <andrew@...akley.name>,
        Chris Boyle <chris@...le.name>,
        "moderated list:SOUND" <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "ALSA: usb-audio: Disable Lenovo P620 Rear line-in volume control"

On Tue, 22 Sep 2020 17:13:05 +0200,
Kai-Heng Feng wrote:
> 
> 
> > On Sep 21, 2020, at 16:40, Takashi Iwai <tiwai@...e.de> wrote:
> > 
> > On Tue, 15 Sep 2020 12:39:23 +0200,
> > Kai-Heng Feng wrote:
> >> 
> >> This reverts commit 34dedd2a83b241ba6aeb290260313c65dc58660e.
> >> 
> >> According to Realtek, volume FU works for line-in.
> >> 
> >> I can confirm volume control works after device firmware is updated.
> > 
> > A slight concern is what happens if you apply this change to the
> > device before the firmware update.
> 
> The desktop that equips with the USB audio device hasn't released to the market yet, so I am not really worried about this.
> 
> > 
> > Also, after this revert, does the mixer control appear properly?
> 
> Yes it does.

Alright, then let's take the patch.
Thanks for clarification.


Takashi