lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Sep 2020 08:47:05 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Eli Cohen <elic@...dia.com>, "Michael S. Tsirkin" <mst@...hat.com> Cc: Leon Romanovsky <leonro@...dia.com>, virtualization@...ts.linux-foundation.org, LKML <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jason Wang <jasowang@...hat.com>, Saeed Mahameed <saeedm@...dia.com> Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors On 9/24/20 3:24 AM, Eli Cohen wrote: > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: >>>> --- linux-next-20200917.orig/drivers/vdpa/Kconfig >>>> +++ linux-next-20200917/drivers/vdpa/Kconfig >>>> @@ -31,7 +31,7 @@ config IFCVF >>>> >>>> config MLX5_VDPA >>>> bool "MLX5 VDPA support library for ConnectX devices" >>>> - depends on MLX5_CORE >>>> + depends on VHOST_IOTLB && MLX5_CORE >>>> default n >>> >>> While we are here, can anyone who apply this patch delete the "default n" line? >>> It is by default "n". > > I can do that > >>> >>> Thanks >> >> Hmm other drivers select VHOST_IOTLB, why not do the same? v1 used select, but Saeed requested use of depends instead because select can cause problems. > I can't see another driver doing that. Perhaps I can set dependency on > VHOST which by itself depends on VHOST_IOTLB? >> >> >>>> help >>>> Support library for Mellanox VDPA drivers. Provides code that is >>>> >> -- ~Randy
Powered by blists - more mailing lists