linux-kernel - Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200924102413.GD170403@mtl-vdi-166.wap.labs.mlnx>
Date:   Thu, 24 Sep 2020 13:24:13 +0300
From:   Eli Cohen <elic@...dia.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     Leon Romanovsky <leonro@...dia.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        <virtualization@...ts.linux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jason Wang <jasowang@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build
 errors

On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote:
> > > --- linux-next-20200917.orig/drivers/vdpa/Kconfig
> > > +++ linux-next-20200917/drivers/vdpa/Kconfig
> > > @@ -31,7 +31,7 @@ config IFCVF
> > >
> > >  config MLX5_VDPA
> > >  	bool "MLX5 VDPA support library for ConnectX devices"
> > > -	depends on MLX5_CORE
> > > +	depends on VHOST_IOTLB && MLX5_CORE
> > >  	default n
> > 
> > While we are here, can anyone who apply this patch delete the "default n" line?
> > It is by default "n".

I can do that

> > 
> > Thanks
> 
> Hmm other drivers select VHOST_IOTLB, why not do the same?

I can't see another driver doing that. Perhaps I can set dependency on
VHOST which by itself depends on VHOST_IOTLB?
> 
> 
> > >  	help
> > >  	  Support library for Mellanox VDPA drivers. Provides code that is
> > >
>