lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Sep 2020 09:04:58 -0700 From: Joe Perches <joe@...ches.com> To: Bartosz Golaszewski <brgl@...ev.pl>, Linus Walleij <linus.walleij@...aro.org>, Jonathan Corbet <corbet@....net>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Kent Gibson <warthog618@...il.com> Cc: linux-gpio@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Bartosz Golaszewski <bgolaszewski@...libre.com> Subject: Re: [PATCH 5/9] gpio: mockup: use pr_fmt() On Thu, 2020-09-24 at 13:38 +0200, Bartosz Golaszewski wrote: > We don't need a custom logging helper. Let's use the standard pr_fmt() > macro which allows us to use all pr_*() routines with custom format. [] > diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c [] > @@ -577,7 +577,7 @@ static int __init gpio_mockup_init(void) > > pdev = platform_device_register_full(&pdevinfo); > if (IS_ERR(pdev)) { > - gpio_mockup_err("error registering device"); > + pr_err("error registering device"); You could add the missing newline at the same time.
Powered by blists - more mailing lists