linux-kernel - RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Sep 2020 00:35:17 +0000
From:   Leo Li <leoyang.li@....com>
To:     Michael Walle <michael@...le.cc>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
CC:     Shawn Guo <shawnguo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Joakim Zhang <qiangqing.zhang@....com>
Subject: RE: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes



> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: Wednesday, September 23, 2020 4:57 AM
> To: linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org; linux-can@...r.kernel.org
> Cc: Shawn Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; Rob
> Herring <robh+dt@...nel.org>; Marc Kleine-Budde <mkl@...gutronix.de>;
> Joakim Zhang <qiangqing.zhang@....com>; Michael Walle
> <michael@...le.cc>
> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
> 
> The LS1028A has two FlexCAN controller. These are compatible with the ones
> from the LX2160A. Add the nodes.
> 
> The first controller was tested on the Kontron sl28 board.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0efeb8fa773e..807ee921ec12 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -386,6 +386,24 @@
>  			status = "disabled";
>  		};
> 
> +		can0: can@...0000 {
> +			compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
> flexcan";

The explicit compatible strings cannot be found in the binding, but matched by the "fsl,<processor>-flexcan" pattern in the binding.  Is this considered to be acceptable now?

> +			reg = <0x0 0x2180000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&sysclk>, <&clockgen 4 1>;
> +			clock-names = "ipg", "per";
> +			status = "disabled";
> +		};
> +
> +		can1: can@...0000 {
> +			compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
> flexcan";
> +			reg = <0x0 0x2190000 0x0 0x10000>;
> +			interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&sysclk>, <&clockgen 4 1>;
> +			clock-names = "ipg", "per";
> +			status = "disabled";
> +		};
> +
>  		duart0: serial@...0500 {
>  			compatible = "fsl,ns16550", "ns16550a";
>  			reg = <0x00 0x21c0500 0x0 0x100>;
> --
> 2.20.1