linux-kernel - Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9347e4c2e070ee9e8aa7a8007d89f02@walle.cc>
Date:   Thu, 24 Sep 2020 13:31:00 +0200
From:   Michael Walle <michael@...le.cc>
To:     Leo Li <leoyang.li@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
        Shawn Guo <shawnguo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Joakim Zhang <qiangqing.zhang@....com>
Subject: Re: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes

Am 2020-09-24 02:35, schrieb Leo Li:
>> -----Original Message-----
>> From: Michael Walle <michael@...le.cc>
>> Sent: Wednesday, September 23, 2020 4:57 AM
>> To: linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; 
>> linux-
>> kernel@...r.kernel.org; linux-can@...r.kernel.org
>> Cc: Shawn Guo <shawnguo@...nel.org>; Leo Li <leoyang.li@....com>; Rob
>> Herring <robh+dt@...nel.org>; Marc Kleine-Budde <mkl@...gutronix.de>;
>> Joakim Zhang <qiangqing.zhang@....com>; Michael Walle
>> <michael@...le.cc>
>> Subject: [PATCH 1/2] arm64: dts: ls1028a: add missing CAN nodes
>> 
>> The LS1028A has two FlexCAN controller. These are compatible with the 
>> ones
>> from the LX2160A. Add the nodes.
>> 
>> The first controller was tested on the Kontron sl28 board.
>> 
>> Signed-off-by: Michael Walle <michael@...le.cc>
>> ---
>>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 18 
>> ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 0efeb8fa773e..807ee921ec12 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -386,6 +386,24 @@
>>  			status = "disabled";
>>  		};
>> 
>> +		can0: can@...0000 {
>> +			compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-
>> flexcan";
> 
> The explicit compatible strings cannot be found in the binding, but
> matched by the "fsl,<processor>-flexcan" pattern in the binding.  Is
> this considered to be acceptable now?

What is the consequence if it is not acceptable? replacing the pattern
with individual compatible strings?

-michael