linux-kernel - Re: [PATCH v2 0/7] KVM: x86: Tracepoint improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c169b328-c14b-d427-d8c9-02eb8278ec75@redhat.com>
Date:   Fri, 25 Sep 2020 23:46:00 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v2 0/7] KVM: x86: Tracepoint improvements and fixes

On 23/09/20 22:13, Sean Christopherson wrote:
> As noted by Vitaly, these changes break trace-cmd[*].  I hereby pinky
> swear that, if this series is merged, I will send patches to update
> trace-cmd.
> 
> [*] git://git.kernel.org/pub/scm/utils/trace-cmd/trace-cmd.git

Actually I think we should just retire the kvm plugin of libtraceevent.
 I do use the plugin myself, but really only because it's enabled by
default.  There's very little that the plugin does better than the
tracepoints and could not be fixed in Linux.

The role in particular is printed better by the plugin, some fields are
missing in KVM_MMU_PAGE_PRINTK().  The only real functionality would be
the disassembling of emulated instructions.

Paolo

> v2:
>   - Fixed some goofs in the changelogs.
>   - Rebased to kvm/queue, commit e1ba1a15af73 ("KVM: SVM: Enable INVPCID
>     feature on AMD").
> 
> Sean Christopherson (7):
>   KVM: x86: Add RIP to the kvm_entry, i.e. VM-Enter, tracepoint
>   KVM: x86: Read guest RIP from within the kvm_nested_vmexit tracepoint
>   KVM: VMX: Add a helper to test for a valid error code given an intr
>     info
>   KVM: x86: Add intr/vectoring info and error code to kvm_exit
>     tracepoint
>   KVM: x86: Add macro wrapper for defining kvm_exit tracepoint
>   KVM: x86: Use common definition for kvm_nested_vmexit tracepoint
>   KVM: nVMX: Read EXIT_QUAL and INTR_INFO only when needed for nested
>     exit
> 
>  arch/x86/include/asm/kvm_host.h |   7 ++-
>  arch/x86/kvm/svm/svm.c          |  16 ++---
>  arch/x86/kvm/trace.h            | 107 +++++++++++++-------------------
>  arch/x86/kvm/vmx/nested.c       |  14 ++---
>  arch/x86/kvm/vmx/vmcs.h         |   7 +++
>  arch/x86/kvm/vmx/vmx.c          |  18 +++++-
>  arch/x86/kvm/x86.c              |   2 +-
>  7 files changed, 86 insertions(+), 85 deletions(-)
> 

Nice.  Queued, thanks.

Paolo