linux-kernel - Re: [PATCH net] net: phy: realtek: fix rtl8211e rx/tx delay config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200925144113.54be6e1b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 25 Sep 2020 14:41:13 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willy Liu <willy.liu@...ltek.com>
Cc:     <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
        <davem@...emloft.net>, <fancer.lancer@...il.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <ryankao@...ltek.com>, <kevans@...eBSD.org>
Subject: Re: [PATCH net] net: phy: realtek: fix rtl8211e rx/tx delay config

On Fri, 25 Sep 2020 15:25:15 +0800 Willy Liu wrote:
> There are two chip pins named TXDLY and RXDLY which actually adds the 2ns
> delays to TXC and RXC for TXD/RXD latching. These two pins can config via
> 4.7k-ohm resistor to 3.3V hw setting, but also config via software setting
> (extension page 0xa4 register 0x1c bit13 12 and 11).
> 
> The configuration register definitions from table 13 official PHY datasheet:
> PHYAD[2:0] = PHY Address
> AN[1:0] = Auto-Negotiation
> Mode = Interface Mode Select
> RX Delay = RX Delay
> TX Delay = TX Delay
> SELRGV = RGMII/GMII Selection

Checkpatch says:

ERROR: do not set execute permissions for source files
#48: FILE: drivers/net/phy/realtek.c

ERROR: trailing whitespace
#91: FILE: drivers/net/phy/realtek.c:266:
+^I * the RX/TX delays otherwise controlled by RXDLY/TXDLY pins. $

total: 2 errors, 0 warnings, 0 checks, 54 lines checked