linux-kernel - Re: [PATCH] leds: lp55xx: fix device node iterator memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200926011612.37a50904@nic.cz>
Date:   Sat, 26 Sep 2020 01:16:12 +0200
From:   Marek Behun <marek.behun@....cz>
To:     Tobias Jordan <kernel@...e.de>
Cc:     linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>
Subject: Re: [PATCH] leds: lp55xx: fix device node iterator memory leaks

On Sat, 26 Sep 2020 00:59:05 +0200
Tobias Jordan <kernel@...e.de> wrote:

> Fix error paths in for_each_child_of_node loops that were missing an
> of_node_put call.
> 
> Fixes: 92a81562e695 ("leds: lp55xx: Add multicolor framework support to
> lp55xx")
> Signed-off-by: Tobias Jordan <kernel@...e.de>
> ---
>  drivers/leds/leds-lp55xx-common.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-lp55xx-common.c b/drivers/leds/leds-lp55xx-common.c
> index 56210f4ad919..f8b55cfd21ef 100644
> --- a/drivers/leds/leds-lp55xx-common.c
> +++ b/drivers/leds/leds-lp55xx-common.c
> @@ -614,8 +614,10 @@ static int lp55xx_parse_multi_led(struct device_node *np,
>  	for_each_child_of_node(np, child) {
>  		ret = lp55xx_parse_multi_led_child(child, cfg, child_number,
>  						   num_colors);
> -		if (ret)
> +		if (ret) {
> +			of_node_put(child);
>  			return ret;
> +		}
>  		num_colors++;
>  	}
>  
> @@ -681,8 +683,10 @@ struct lp55xx_platform_data *lp55xx_of_populate_pdata(struct device *dev,
>  
>  	for_each_child_of_node(np, child) {
>  		ret = lp55xx_parse_logical_led(child, cfg, i);
> -		if (ret)
> +		if (ret) {
> +			of_node_put(child);
>  			return ERR_PTR(-EINVAL);
> +		}
>  		i++;
>  	}
>  

This is already patched