linux-kernel - Re: [f2fs-dev] KMSAN: uninit-value in f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36d3ddc1-e8d1-6d0e-c1ea-aff198740182@kernel.org>
Date:   Sat, 26 Sep 2020 07:17:09 +0800
From:   Chao Yu <chao@...nel.org>
To:     Eric Biggers <ebiggers@...nel.org>, Chao Yu <yuchao0@...wei.com>
Cc:     syzbot <syzbot+0eac6f0bbd558fd866d7@...kaller.appspotmail.com>,
        glider@...gle.com, jaegeuk@...nel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [f2fs-dev] KMSAN: uninit-value in f2fs_lookup

On 2020-9-26 0:45, Eric Biggers wrote:
> On Fri, Sep 25, 2020 at 09:38:19AM -0700, Eric Biggers wrote:
>> On Fri, Sep 25, 2020 at 05:06:33PM +0800, Chao Yu wrote:
>>> Hi,
>>>
>>> I don't see any problem here, thanks for your report. :)
>>>
>>> Thanks,
>>
>> What about if max_depth == 0 in __f2fs_find_entry()?  Then __f2fs_find_entry()
>> would return NULL without initializing *res_page.
>
> ... and I now see Dan Carpenter already pointed this out.  I was a bit late!

Thanks for your check as well. :)

Thanks,

>
> - Eric
>