[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200925234504.GA18813@agrajag.zerfleddert.de>
Date: Sat, 26 Sep 2020 01:45:04 +0200
From: Tobias Jordan <kernel@...e.de>
To: linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Linus Walleij <linus.walleij@...aro.org>
Subject: [PATCH] bus: qcom: ebi2: fix device node iterator leak
In the for_each_available_child_of_node loop of qcom_ebi2_probe, add a
call to of_node_put to avoid leaking the iterator if we bail out.
Fixes: 335a12754808 ("bus: qcom: add EBI2 driver")
Signed-off-by: Tobias Jordan <kernel@...e.de>
---
drivers/bus/qcom-ebi2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c
index 03ddcf426887..0b8f53a688b8 100644
--- a/drivers/bus/qcom-ebi2.c
+++ b/drivers/bus/qcom-ebi2.c
@@ -353,8 +353,10 @@ static int qcom_ebi2_probe(struct platform_device *pdev)
/* Figure out the chipselect */
ret = of_property_read_u32(child, "reg", &csindex);
- if (ret)
+ if (ret) {
+ of_node_put(child);
return ret;
+ }
if (csindex > 5) {
dev_err(dev,
--
2.20.1
Powered by blists - more mailing lists